Skip to main content

Bug Tracker

Side navigation

#6677 closed bug (fixed)

Opened June 15, 2010 10:31PM UTC

Closed September 24, 2010 09:47PM UTC

Missing var declarations

Reported by: msamuel Owned by:
Priority: undecided Milestone: 1.4.3
Component: ajax Version: 1.4.2
Keywords: Cc:
Blocked by: Blocking:
Description

The attached diff from version 1.4.3pre shows some missing var declarations and a buggy exception handler.

It was derived by running dist/jquery.js

Attachments (1)
Change History (4)

Changed June 15, 2010 10:33PM UTC by msamuel comment:1

It was derived by running dist/jquery.js through http://caja.appspot.com/tools/

Changed July 12, 2010 12:30AM UTC by dmethvin comment:2

need: ReviewCommit

Some of those are okay, the variables are declared upfunction. If they are declared with "var" in both places, jslint will whine. I tend to agree with caja and declare it var everywhere in my own code.

Fixes for the two bugs:

http://github.com/dmethvin/jquery/commit/0a1a8605a040c0f7aedb1df6bb4942383f4550b4

http://github.com/dmethvin/jquery/commit/ab89a1b2cff4b02b0ce6e5ca35aed4fbd2c478d5

Changed July 12, 2010 12:30AM UTC by dmethvin comment:3

component: unfiledajax

Changed September 24, 2010 09:47PM UTC by john comment:4

priority: → undecided
resolution: → fixed
status: newclosed