Bug Tracker

Ticket #6677 (closed bug: fixed)

Opened 5 years ago

Last modified 4 years ago

Missing var declarations

Reported by: msamuel Owned by:
Priority: undecided Milestone: 1.4.3
Component: ajax Version: 1.4.2
Keywords: Cc:
Blocking: Blocked by:

Description

The attached diff from version 1.4.3pre shows some missing var declarations and a buggy exception handler.

It was derived by running dist/jquery.js

Attachments

1.4.3.pre_dist_jquery_diff.txt Download (1.9 KB) - added by msamuel 5 years ago.
Diff after running linter over dist/jquery.js

Change History

Changed 5 years ago by msamuel

Diff after running linter over dist/jquery.js

comment:1 Changed 5 years ago by msamuel

It was derived by running dist/jquery.js through  http://caja.appspot.com/tools/

comment:2 Changed 4 years ago by dmethvin

  • need changed from Review to Commit

Some of those are okay, the variables are declared upfunction. If they are declared with "var" in both places, jslint will whine. I tend to agree with caja and declare it var everywhere in my own code.

Fixes for the two bugs:

 http://github.com/dmethvin/jquery/commit/0a1a8605a040c0f7aedb1df6bb4942383f4550b4

 http://github.com/dmethvin/jquery/commit/ab89a1b2cff4b02b0ce6e5ca35aed4fbd2c478d5

comment:3 Changed 4 years ago by dmethvin

  • Component changed from unfiled to ajax

comment:4 Changed 4 years ago by john

  • Priority set to undecided
  • Status changed from new to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.