Missing var declarations

Reported by:	msamuel	Owned by:
Priority:	undecided	Milestone:	1.4.3
Component:	ajax	Version:	1.4.2
Keywords:		Cc:
Blocked by:		Blocking:

Description

The attached diff from version 1.4.3pre shows some missing var declarations and a buggy exception handler.

It was derived by running dist/jquery.js

Attachments (1)

1.4.3.pre_dist_jquery_diff.txt (1.9 KB) - added by msamuel June 15, 2010 10:32PM UTC.

Diff after running linter over dist/jquery.js

Change History (4)

Changed June 15, 2010 10:33PM UTC by msamuel comment:1

It was derived by running dist/jquery.js through http://caja.appspot.com/tools/

Changed July 12, 2010 12:30AM UTC by dmethvin comment:2

need:	Review → Commit

Some of those are okay, the variables are declared upfunction. If they are declared with "var" in both places, jslint will whine. I tend to agree with caja and declare it var everywhere in my own code.

Fixes for the two bugs:

http://github.com/dmethvin/jquery/commit/0a1a8605a040c0f7aedb1df6bb4942383f4550b4

http://github.com/dmethvin/jquery/commit/ab89a1b2cff4b02b0ce6e5ca35aed4fbd2c478d5

Changed July 12, 2010 12:30AM UTC by dmethvin comment:3

component:	unfiled → ajax

Changed September 24, 2010 09:47PM UTC by john comment:4

priority:	→ undecided
resolution:	→ fixed
status:	new → closed

Fixed http://github.com/jquery/jquery/commit/1130beb72be9d9f5d6bb6f303501da5ec2e3744e

Side navigation