Bug Tracker

#6088 closed bug (fixed)

Opened February 12, 2010 04:34PM UTC

Closed September 22, 2010 08:42PM UTC

Last modified March 14, 2012 12:02AM UTC

Height/Width sometimes returns document dimensions in Opera

Reported by: lavignep Owned by:
Priority: Milestone: 1.4.3
Component: dimensions Version: 1.4.2
Keywords: height width opera Cc:
Blocked by: Blocking:
Description

I seems that Opera (tested only on version 10) has a scrollTo function on some elements which defeats the

("scrollTo" in elem && elem.document) test in these methods.

Anyhow, any elements in any browsers could defeat this test.

Attachments (0)
Change History (8)

Changed February 18, 2010 04:35PM UTC by matzes comment:1

I have also a problem with returning document dimension in Opera.

When I disable the prototype-library it works fine on my website.

JS Bin - Testpage:

without prototype: http://jsbin.com/eheju

with prototype: http://jsbin.com/eheju/2

JavaScript:

jQuery(function() {
  var i = jQuery("#test");
  i.text(".width() of red box: " + i.width() + "px (css: 300px)");
});

HTML (with prototype):

<!DOCTYPE html>
<html>
<head>
  <script  class="jsbin" src="http://ajax.googleapis.com/ajax/libs/prototype/1/prototype.js"></script>
  <script class="jsbin" src="http://ajax.googleapis.com/ajax/libs/jquery/1/jquery.min.js"></script>
 <script>     
   jQuery.noConflict();  
 </script>   
<meta charset=utf-8 />
<title>Bug Test</title>
<style>
  #test { width:300px; background:#c00; }
</style>
</head>
<body>
  <div id="test"></div>
</body>
</html>

Changed March 15, 2010 06:48PM UTC by gbilotta comment:2

Same issue here. For some reason, the HTMLElement prototype seems to include all the window methods, so "does it walk and quack like a window?" becomes true even though the element is _not_ the window. The change was introduced in [6313] to make it work with non-main windows and documents, but it's a little too liberal.

A possible solution is to replace that line with:

  return ("scrollTo" in elem && elem.document && !elem.parentNode) ? // does it walk and quack like a window?

with the rationale that HTML elements have a parentNode while windows and documents don't.

Changed March 16, 2010 12:48AM UTC by gbilotta comment:3

Posted the fix here: http://github.com/Oblomov/jquery/commit/f1fd7952743ce4a07a556f1f9a1ba175dd7bca5c

Changed March 30, 2010 09:34AM UTC by kof13 comment:4

Thank you for the fix, its really a blocker.

Changed April 19, 2010 12:53AM UTC by dmethvin comment:5

need: Review → Commit

Changed May 14, 2010 10:28PM UTC by sitkatech comment:6

Replying to [comment:3 gbilotta]:

Posted the fix here: http://github.com/Oblomov/jquery/commit/f1fd7952743ce4a07a556f1f9a1ba175dd7bca5c

What's the status of this fix? Is it going to be committed to the central repository? We're having this problem and prefer not to be on a branch at this time. We've noticed this ticket was for milestone 1.4.2 but it never made it into the release. Any chance of getting this in to 1.4.3? Thanks...

Changed September 08, 2010 12:15PM UTC by phildriscoll comment:7

See also http://dev.jquery.com/ticket/6575#comment:5 for a slightly different fix, and note that this problem occurs in two places in the jQuery source.

Changed September 22, 2010 08:42PM UTC by john comment:8

component: css → dimensions
milestone: 1.4.2 → 1.4.3
resolution: → fixed
status: new → closed
version: 1.4.1 → 1.4.2

Fixed http://github.com/jquery/jquery/commit/c8dd49f756562fef68f664869952e4f5aab08acd