Bug Tracker

Modify ↓

Ticket #5910 (closed bug: fixed)

Opened 2 years ago

Last modified 2 years ago

In 1.4, show/hide methods call animate() when speed is false or empty string

Reported by: kswedberg Owned by:
Priority: major Milestone: 1.4.1
Component: effects Version: 1.4
Keywords: Cc:
Blocking: Blocked by:

Description

This isn't necessarily wrong, but it's different from previous versions, so I changed the conditional from:

if ( speed != null )

to:

if ( speed
speed === 0 )

I committed the change to my fork on Github:  http://github.com/kswedberg/jquery/commit/e708de615723fbff3d121be00c2e4da60fcc72bd

And committed some tests:  http://github.com/kswedberg/jquery/commit/a67e074225da785670a170084fbbb490a6915f1e

Change History

comment:1 Changed 2 years ago by john

  • Status changed from new to closed
  • Resolution set to fixed
  • Component changed from unfilled to fx

Landed.  http://github.com/jquery/jquery/commit/21441b1cbc7a205e621b8c94a21eff102380ca03  http://github.com/jquery/jquery/commit/a63754aa4e4e430007208d6b5cb76f9ca8c279f5

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View ↑

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.