Bug Tracker

Modify

Ticket #5775 (closed bug: worksforme)

Opened 4 years ago

Last modified 4 years ago

animate uses Node.ELEMENT and not Node.ELEMENT_NODE

Reported by: wholcomb Owned by:
Priority: major Milestone: 1.4
Component: effects Version: 1.4
Keywords: Cc:
Blocking: Blocked by:

Description

The w3c spec specifies the constant for an element node is Node.ELEMENT_NODE.

 http://www.w3.org/TR/2000/REC-DOM-Level-2-Core-20001113/ecma-script-binding.html

The animate function has the line:

var hidden = this.nodeType == Node.ELEMENT && jQuery(this).is(":hidden");

This fails on documents loaded with a application/xhtml+xml mimetype in Firefox 3.5.

var hidden = (this.nodeType == Node.ELEMENT
this.nodeType == Node.ELEMENT_NODE) && jQuery(this).is(":hidden");

Works.

Change History

comment:1 Changed 4 years ago by dmethvin

  • Component changed from unfiled to fx

comment:2 Changed 4 years ago by dmethvin

  • Status changed from new to closed
  • Resolution set to worksforme

Not sure where you're seeing Node.ELEMENT; in the uncompressed standard jQuery files, nodeType is compared to the actual integer value of 1 to see if it's an element node.

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.