$.extend copies by reference, even with deep=true (patch)

a = { arr: [1, 2, 3] }

b = $.extend(true, {}, a)

b.arr.pop()

// Should be false, but is true

a.arr === b.arr

Attachments (1)

deep-extend-array.patch (2.4 KB) - added by fortes January 04, 2010 09:18PM UTC.

Change History (4)

With real formatting:

a = { arr: [1, 2, 3] }
b = $.extend(true, {}, a)
b.arr.pop()

// Should be false, but is true
a.arr === b.arr

I shouldn't continue to code on low sleep, but here's a more compact version (ignore the attached patch): http://github.com/fortes/jquery/commit/8c77139415ba86024b545dde326e9fee9b06fb4c

resolution:	→ fixed
status:	new → closed

Landed.

Side navigation