Ticket #5679 (closed enhancement: fixed)
Google closure-compiler compiled version of jQuery
| Reported by: | othree | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.4 |
| Component: | core | Version: | 1.4a2 |
| Keywords: | Cc: | ||
| Blocking: | Blocked by: |
Description
Maybe you can support a closure-compiled version of jQuery while 1.4 is out. It's much smaller than the yuicompressor compressed version.
- yuicompressor -> 92583 bytes
- closure(simple) -> 67370 bytes
- closure(advanced) -> 61458 bytes
And, while using closure-compiler. There are 3 warning messages:
jquery-1.4a2.js:2467: WARNING - Suspicious code. This code lacks side-effects. Is there a bug?
elem.parentNode.selectedIndex;
jquery-1.4a2.js:3536: WARNING - Suspicious code. This code lacks side-effects. Is there a bug?
if ( name === "selected" && elem.parentNode ) {
jquery-1.4a2.js:3537: WARNING - Suspicious code. This code lacks side-effects. Is there a bug?
elem.parentNode.selectedIndex;
0 error(s), 3 warning(s)
Maybe you can take a look at these codes before release
Change History
Please follow the bug reporting guidlines and use jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.
Fixed. http://github.com/jquery/jquery/commit/3fd62eae9df3159fc238a515bb748140a942313d