Memory leak when jsonp $.ajax() request fails.

[sigmunau]

jsonp ajax requests does some explicit garbage collection when the jsonp request succeeds. but this code is missing from the error paths. Attached patch fixes the memory leak and also fixes a case where error callback isn't run because firefox throws an exception on xhr.open() for certain malformed urls.

[sigmunau]

attempted fix for timeout and 404 (etc) errors with jsonp requests

[sigmunau]

Second patch uses a trick with a timer to make sure error callback is called, and resources cleaned up when the browser is unable to fetch the jsonp data for some more reasons, including 404 response from server or network issues making the server unreachable. I'm not 100% sure this is correct but it seems to work in my test cases

[somnus]

$.ajax() does not work.

[rwaldron]

This needs to be reverified with the new ajax module.

[anonymous]

$.ajax is seriously flawed after 1.4.2 !!!

protocol = loc.protocol

"http:",

protocol may be WRITEONLY, thus this will generate an uncaught exception.

Please fix it !!!!!

[jitter]

Replying to anonymous:

$.ajax is seriously flawed after 1.4.2 !!!

protocol = loc.protocol

"http:",

protocol may be WRITEONLY, thus this will generate an uncaught exception.

Please fix it !!!!!

This comment is totally unrelated to this ticket. Also please use less exclamation marks. You probably are looking for #8138

[addyosmani]

Unless I'm missing something, we're going to need a new test case that we can use to verify this behaviour with the ajax rewrite that landed in 1.5. CC'ing jaubourg in case he knows whether this is still an issue or not.

[jaubourg]

It will memleak and there is nothing that can be done save from setting a timeout as suggested (which won't work for long-polling).

There is no way to handle errors cross-browser for injected script tags, so any network error will leave the script tag dangling and memory will leak.

We could fix the issue for jsonp but it would involve duplicating code for script tag injection and I'm not sure it is something we want to do.

If you want better cross-domain script loading support, I suggest petitionning browser vendors so that we have a proper mean to load scripts WITHOUT script tag injection (or, at the very least, petition Opera so that they provide the, non-standard-yet-available-everywhere-else, onerror handler).

I'll close this as patch welcome but I passed quite some days to try and figure out a proper solution to no avail.