Side navigation
#4969 closed bug (wontfix)
Opened July 24, 2009 08:33PM UTC
Closed November 19, 2010 08:10AM UTC
filter.length check in testrunner.js
| Reported by: | jnorell | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.4 |
| Component: | misc | Version: | 1.3.2 |
| Keywords: | testrunner.js Galio | Cc: | |
| Blocked by: | Blocking: |
Description
Trying to run the test suite in Galio browser, validTest() is returning false for everything. The name.indexOf(filter) check there returns -1 in Galio, whereas it returns 0 in iceape. As best I can tell, Galio is actually correct on this one. The attached tweak has them both working (skips that test if the filter is empty).
Note, the logic in this patch may not be correct (it returns "true" if any of the filters are empty?) - but I'm not entirely sure the rest of the test there is correct, either (it looks like if multiple filters are specified, if any of them do not match, the test is deemed valid ... I've not dug into how those filters are supposed to work, as it looks like in practice they are never set.)