Bug Tracker

Modify

Ticket #474 (closed bug: fixed)

Opened 6 years ago

Last modified 6 years ago

oneclick with return false doesn't return false svn $Rev: 670 $

Reported by: jakecigar@… Owned by:
Priority: major Milestone:
Component: core Version:
Keywords: click callback svn Cc: jörn
Blocking: Blocked by:

Description

I use oneclick() on an a and inside the callback I return false, to not execute the a.

when I upgraded to the latest svn version... it seems not to be returning my false, the a is invoked and I leave my page.

it worked on $Rev: 415 $ (and still does work with 415)

the callback code was pared down to an alert and a return false, it still doesn't work.

Change History

comment:1 Changed 6 years ago by jakecigar@…

bug found at line 1551 of event.js

f.apply(this, arguments);

should be

return f.apply(this, arguments);

Please verify and commit.

THANKS

comment:2 Changed 6 years ago by jakecigar@…

not sure that is enough... I've stopped using oneclick. I liked the old code better!

comment:3 Changed 6 years ago by joern

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in SVN, adding the return statement fixed the problem.

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.