Bug Tracker

Modify

Ticket #4311 (closed enhancement: fixed)

Opened 4 years ago

Last modified 15 months ago

remove "parseInt" and speed up some div

Reported by: roviury Owned by:
Priority: major Milestone: 1.4
Component: unfiled Version: 1.3.2
Keywords: Cc:
Blocking: Blocked by:

Description

remove "parseInt": parseInt(x,10) = (x-0) but (x-0) is faster

the lines is the problem refer to... 1048:

(parseInt( value ) + == "NaN" ? "" : "alpha(opacity=" + value * 100 + ")"); (( value -0 ) + == "NaN" ? "" : "alpha(opacity=" + value * 100 + ")");

1267:

return elem[0] && parseInt( jQuery.curCSS(elem[0], prop, true), 10 ) return elem[0] && ( jQuery.curCSS(elem[0], prop, true)-0 )
0;
0;

4200-4201:

top += parseInt( computedStyle.borderTopWidth, 10) left += parseInt( computedStyle.borderLeftWidth, 10) top += ( computedStyle.borderTopWidth-0 ) left += ( computedStyle.borderLeftWidth-0 )
0,
0;
0,
0;

4205-4206:

top += parseInt( computedStyle.borderTopWidth, 10) left += parseInt( computedStyle.borderLeftWidth, 10) top += ( computedStyle.borderTopWidth-0 ) left += ( computedStyle.borderLeftWidth-0 )
0,
0;
0,
0;

4252-4253:

top += parseInt( jQuery.curCSS(body, 'marginTop', true), 10 ) left += parseInt( jQuery.curCSS(body, 'marginLeft', true), 10 ) top += ( jQuery.curCSS(body, 'marginTop', true)-0 ) left += ( jQuery.curCSS(body, 'marginLeft', true)-0 )
0,
0;
0,
0;

speed up some div: x/100 = x * 1/100 = x * 0.01 but *0.01 faster than /100 (in most browser can speed up, even if not, it must not speed down) ps.why is some div? the dividend must be constant!

1052: (parseFloat( elem.filter.match(/opacity=([)]*)/)[1] ) / 100) + : (parseFloat( elem.filter.match(/opacity=([)]*)/)[1] ) * 0.01) + :

Attachments

jquery-1.3.2_.js Download (122.0 KB) - added by roviury 4 years ago.
improvement

Change History

Changed 4 years ago by roviury

improvement

comment:1 Changed 4 years ago by roviury

remove "parseInt": parseInt(x,10) = (x-0) but (x-0) is faster

the lines is the problem refer to...

1048:

(parseInt( value ) + == "NaN" ? "" : "alpha(opacity=" + value * 100 + ")"); (( value -0 ) + == "NaN" ? "" : "alpha(opacity=" + value * 100 + ")");

1267 :

return elem[0] && parseInt( jQuery.curCSS(elem[0], prop, true), 10 ) return elem[0] && ( jQuery.curCSS(elem[0], prop, true)-0 )
0;
0;

4200-4201 :

top += parseInt( computedStyle.borderTopWidth, 10) left += parseInt( computedStyle.borderLeftWidth, 10) top += ( computedStyle.borderTopWidth-0 ) left += ( computedStyle.borderLeftWidth-0 )
0,
0;
0,
0;

4205-4206 :

top += parseInt( computedStyle.borderTopWidth, 10) left += parseInt( computedStyle.borderLeftWidth, 10) top += ( computedStyle.borderTopWidth-0 ) left += ( computedStyle.borderLeftWidth-0 )
0,
0;
0,
0;

4252-4253 :

top += parseInt( jQuery.curCSS(body, 'marginTop', true), 10 ) left += parseInt( jQuery.curCSS(body, 'marginLeft', true), 10 ) top += ( jQuery.curCSS(body, 'marginTop', true)-0 ) left += ( jQuery.curCSS(body, 'marginLeft', true)-0 )
0,
0;
0,
0;

speed up some div : x/100 = x * 1/100 = x * 0.01 but *0.01 faster than /100 (in most browser can speed up, even if not, it must not speed down) ps.why is some div? the dividend must be constant!

1052 : (parseFloat( elem.filter.match(/opacity=([)]*)/)[1] ) / 100) + : (parseFloat( elem.filter.match(/opacity=([)]*)/)[1] ) * 0.01) + :

comment:2 Changed 3 years ago by dmethvin

  • Status changed from new to closed
  • Resolution set to fixed

I don't see this code in jQuery core anymore, so I'll it was fixed or rewritten.

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.