Bug Tracker

#4270 closed bug (fixed)

Opened February 27, 2009 11:15PM UTC

Closed November 09, 2009 11:08AM UTC

Remove the use of nonstandard properties leftContext and rightContext

Reported by: metaweta Owned by: john
Priority: major Milestone: 1.4
Component: selector Version: 1.3.2
Keywords: Cc:
Blocked by: Blocking:
Description

Removes the dependence on the nonstandard RegExp properties leftContext and rightContext. Also removes the dependence on lastIndex, which can't be exposed in Caja because it is static shared state, which leaks information across gadget boundaries.

Attachments (1)
  • sizzle.diff (2.1 KB) - added by metaweta February 28, 2009 04:47PM UTC.
Change History (3)

Changed February 28, 2009 03:31PM UTC by metaweta comment:1

Sorry, this patch only removes rightContext. Will follow up with a patch removing leftContext and lastIndex.

Changed February 28, 2009 04:42PM UTC by metaweta comment:2

OK, patch corrected. The attached patch now does what the original description says.

Changed November 09, 2009 11:08AM UTC by john comment:3

resolution: → fixed
status: new → closed

Fixed in Sizzle.

http://github.com/jeresig/sizzle/commit/2f1f9a1795c6790983d583155354da984d433ef6