Bug Tracker

Modify ↓

Ticket #4270 (closed bug: fixed)

Opened 4 years ago

Last modified 4 years ago

Remove the use of nonstandard properties leftContext and rightContext

Reported by: metaweta Owned by: john
Priority: major Milestone: 1.4
Component: selector Version: 1.3.2
Keywords: Cc:
Blocking: Blocked by:

Description

Removes the dependence on the nonstandard RegExp properties leftContext and rightContext. Also removes the dependence on lastIndex, which can't be exposed in Caja because it is static shared state, which leaks information across gadget boundaries.

Attachments

sizzle.diff Download (2.1 KB) - added by metaweta 4 years ago.

Change History

comment:1 Changed 4 years ago by metaweta

Sorry, this patch only removes rightContext. Will follow up with a patch removing leftContext and lastIndex.

comment:2 Changed 4 years ago by metaweta

OK, patch corrected. The attached patch now does what the original description says.

Changed 4 years ago by metaweta

comment:3 Changed 4 years ago by john

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in Sizzle.  http://github.com/jeresig/sizzle/commit/2f1f9a1795c6790983d583155354da984d433ef6

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View ↑

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.