New :visible logic fails on hidden table rows in IE7

[cmlenz]

The new :visible logic introduced in 1.3.2 doesn't work correctly for hidden table rows in IE7, and probably IE6. Haven't tested IE8.

The issue is that IE still reports a >0 offsetWidth for the rows, only the offsetHeight is ==0. I'll attach a simple HTML page that demonstrates the problem.

I think the fix would be:

Index: src/selector.js
===================================================================
--- src/selector.js	(revision 6253)
+++ src/selector.js	(working copy)
@@ -958,7 +958,7 @@
 };
 
 Sizzle.selectors.filters.visible = function(elem){
-	return elem.offsetWidth > 0 || elem.offsetHeight > 0;
+	return elem.offsetWidth > 0 && elem.offsetHeight > 0;
 };
 
 Sizzle.selectors.filters.animated = function(elem){

[cmlenz]

HTML test page

[dmethvin]

I tried a simple test case and it seems to work correctly with 1.3.2 in IE8 (all I have on this PC). Can you attach a case that fails in IE7 just to be sure?

[jerone]

The test case fails correctly for IE6, IE7, IE8 RC1 for me.

[Heliologue]

I can confirm this in IE6 and IE7.

[Heliologue]

This ticket is duplicated (and fixed) in #4374. Looks like the aforementioned change to {{selector.js}} was made in r6282.

[dmethvin]

Dup/fixed #4374. Thanks Heliologue!