$.extend erratic behavior with objects that have a length property

Reported by:	dmethvin	Owned by:
Priority:	low	Milestone:	1.4
Component:	core	Version:	1.3.2
Keywords:		Cc:
Blocked by:		Blocking:

Description

From the jQuery Google Group:

http://groups.google.com/group/jquery-en/browse_frm/thread/31e97b11082d2633#

Hello,

It seems that it's not safe to use "length" as a nested object

property if I want to use jquery.extend. Is this a know issue?

$.extend(true, {},{"prop":{"length":"-1"}});

thanks,

-Morgan

Attachments (1)

extend_object_with_length.patch (1.7 KB) - added by JDay March 20, 2009 07:22AM UTC.

Fix and testcase. Use jQuery.isArray() istead of checking for a length property.

Change History (4)

Changed March 21, 2009 05:10PM UTC by dmethvin comment:1

That would only handle true

Array

objects. I think the goal may have been to have

$.extend

be able to take array-like objects and treat them like Array, e.g., Function.arguments and DOM nodeList. It's worth thinking about so I'll leave the ticket open for further discussion.

Changed April 21, 2009 07:43PM UTC by JDay comment:2

"Array-like" objects can still be handled and should work as before. Where is the value in making a "true" Array out of an object that wasn't an array to begin with?

Changed October 27, 2010 01:23AM UTC by rwaldron comment:3

resolution:	→ worksforme
status:	new → closed

Additional testing:

http://jsfiddle.net/rwaldron/nqnBr/2/

I don't think there is any misbehaviour here. I'm closing, if the author wants to reopen, then we can do so with valid reason.

Changed October 27, 2010 01:23AM UTC by rwaldron comment:4

priority:	minor → low

Side navigation