Bug Tracker

#4206 closed enhancement (fixed)

Opened February 20, 2009 09:36PM UTC

Closed December 07, 2009 01:18AM UTC

Patch: JSONP: Support callbackName to request content with a constant URL

Reported by: ion Owned by:
Priority: minor Milestone: 1.4
Component: ajax Version: 1.4a1
Keywords: jsonp callback Cc:
Blocked by: Blocking:
Description

Say, your page requests http://ws.audioscrobbler.com/2.0/?method=user.getweeklyartistchart&user=...&format=json&callback=foo using JSONP. The response doesn’t change often and it isn’t urgent to get the most recent possible version.

Currently the callback name will be different for each request. If there were a way to keep the callback name constant for that specific request, both the browser and the server could cache the content.

The attached patch implements the callbackName parameter for $.ajax, so that

$.ajax ({
  url:          'http://ws.audioscrobbler.com/...&callback=?',
  success:      ...,
  dataType:     'json',
  callbackName: 'AudioScrobblerChart'
});

requests http://ws.audioscrobbler.com/...&callback=jsonpAudioScrobblerChart.

The patch throws an error if the programmer uses the same callbackName twice simultaneously.

Attachments (1)
Change History (3)

Changed February 21, 2009 01:25AM UTC by john comment:1

resolution: → wontfix
status: new → closed

It doesn't really seem like this is needed. If you're really worried about static naming you could just do:

$.ajax ({
  url:          'http://ws.audioscrobbler.com/...&callback=AudioScrobblerChart',
  dataType:     'script'
});

function AudioScrobblerChart(json){
   // do stuff with the JSON
}

...which isn't really a huge stretch.

Changed August 26, 2009 08:44AM UTC by tudor_s comment:2

resolution: wontfix
status: closed → reopened

I also came about making the same patch as posted here. It would really benefit caching by having this option. Especially when you want your other jQuery plugins to use the same settings without the need to change the way they request data.

Therefore this change would really be appreciated, especially when it comes with a small cost to implementing it.

Thank you.

Changed December 07, 2009 01:18AM UTC by john comment:3

resolution: → fixed
status: reopened → closed
version: 1.3.2 → 1.4a1

Fixed.

http://github.com/jquery/jquery/commit/fbc73d45b487dd863886c7fd3f0af1fd4dec261b