Bug Tracker

Modify

Ticket #4001 (closed bug: fixed)

Opened 4 years ago

Last modified 4 years ago

setInterval leak in function custom

Reported by: arrix Owned by:
Priority: major Milestone: 1.3.2
Component: effects Version: 1.3.1
Keywords: Cc:
Blocking: Blocked by:

Description

jQuery.fx.prototype.custom uses jQuery.timers.push(t) == 1 as a guard condition for the setInterval call, which is not robust enough. In the test case, stop, which empties jQuery.timers, is called before animate so that the check will pass even though there is already an active interval. This causes a leak because timerId gets overwritten every time and there is no way to clearInterval.

Attachments

animation_guard.html Download (905 bytes) - added by arrix 4 years ago.
fx_interval.patch Download (490 bytes) - added by arrix 4 years ago.

Change History

Changed 4 years ago by arrix

Changed 4 years ago by arrix

comment:1 Changed 4 years ago by john

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in SVN rev [6194].

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.