Skip to main content

Bug Tracker

Side navigation

#3702 closed enhancement (fixed)

Opened December 09, 2008 01:23AM UTC

Closed December 25, 2008 05:10PM UTC

Last modified March 14, 2012 10:47PM UTC

Math.max should be able to handle more than two args

Reported by: lrbabe Owned by: flesler
Priority: trivial Milestone: 1.3
Component: dimensions Version: 1.2.6
Keywords: Cc: lrbabe
Blocked by: Blocking:
Description

We can spare some bytes and be more efficient by removing unnecessary use of Math.max

The syntax:

Math.max( Math.max(1,2), Math.max(3,4) )

can be replaced by this one:

Math.max( 1, 2, 3, 4 )

Attachments (1)
  • patch.txt (0.8 KB) - added by lrbabe December 09, 2008 01:23AM UTC.

    patch to remove unnecessary use of Math.max

Change History (2)

Changed December 11, 2008 12:29PM UTC by flesler comment:1

cc: → lrbabe
component: coredimensions
owner: → flesler
status: newassigned

Will look into this for 1.3.

Thanks!

Changed December 25, 2008 05:10PM UTC by flesler comment:2

resolution: → fixed
status: assignedclosed

Fixed at [5985].