Bug Tracker

Modify

Ticket #3649 (closed bug: fixed)

Opened 5 years ago

Last modified 15 months ago

Can't set tabindex using attr() in IE - patch supplied

Reported by: jollytoad Owned by: flesler
Priority: minor Milestone: 1.3
Component: core Version: 1.2.6
Keywords: tabindex attr Cc: jollytoad
Blocking: Blocked by:

Description

IE only allows the tabindex to be set with the tabIndex property, so .attr('tabindex', ...) does not work. I've added it to jQuery.props list and it works in IE, FF, Opera, and Chrome. Safari doesn't seems to respond to tabindex like any other browser anyway! Anyway, test case and patch attached.

Attachments

tabindex.html Download (464 bytes) - added by jollytoad 5 years ago.
Test page
tabindex-jquery.patch Download (323 bytes) - added by jollytoad 5 years ago.
Patch for core,js against SVN rev 5949
tabindex.patch Download (4.4 KB) - added by scott.gonzalez 4 years ago.
tabindex.2.patch Download (5.8 KB) - added by scott.gonzalez 4 years ago.

Change History

Changed 5 years ago by jollytoad

Test page

Changed 5 years ago by jollytoad

Patch for core,js against SVN rev 5949

comment:1 Changed 4 years ago by flesler

  • Cc jollytoad added
  • Owner set to flesler
  • Status changed from new to assigned

That's odd. I thought I added tabIndex to $.props. I'll add it asap.

It's odd that it still doesn't work on Safari. Does it work properly if you use the expando directly ?

comment:2 Changed 4 years ago by scott.gonzal

The tabindex problem is actually larger than just capitalization. There's a  related ticket in jQuery UI that covers all of the problems. There are plenty of links to additional resources in that ticket as well (some of the topics aren't relevant to core). You can see the current progress in the  tabbable branch. We'll update this ticket when we finalize our proxy of $.attr.

Changed 4 years ago by scott.gonzalez

comment:3 Changed 4 years ago by scott.gonzal

Added a patch with tests that makes getting and setting tabindex work in all browsers.

Changed 4 years ago by scott.gonzalez

comment:4 Changed 4 years ago by scott.gonzal

New patch adds comments and fixes selector tests.

comment:5 Changed 4 years ago by john

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed in SVN rev [6043].

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.