Bug Tracker

Ticket #3539 (closed feature: fixed)

Opened 6 years ago

Last modified 6 years ago

Expose the queueing system, make it generic and create a 'data' module

Reported by: flesler Owned by: flesler
Priority: major Milestone: 1.3
Component: data Version: 1.2.6
Keywords: Cc: john, joern, brandon, davidserduke
Blocking: Blocked by:

Description (last modified by flesler) (diff)

I propose putting all the data/queue functions and related variables into a new module, called data.

Also expose the generic queueing function that is actually a local function. I also want to make it generic, along with dequeue. Both are merely intended for animations.

Attachments

queue[5917].diff Download (8.5 KB) - added by flesler 6 years ago.

Change History

comment:1 Changed 6 years ago by flesler

  • Status changed from new to assigned
  • Description modified (diff)
  • Summary changed from Expose the queue function as jQuery.queue to Expose the queueing system, make it generic and create a 'data' module

Changed 6 years ago by flesler

comment:2 Changed 6 years ago by flesler

  • Cc john, joern, brandon, davidserduke added
  • need changed from Patch to Commit

I run the suite on most browsers and tried this much.

comment:3 Changed 6 years ago by john

Looks good to me! I'm not a huge fan of .nextAnim() (seems like it's used so infrequently to begin with, we could probably just inline it) but that's something that we can always mess with later.

comment:4 Changed 6 years ago by flesler

I don't like the name either and yes, making it private sounds good to me too.

comment:5 Changed 6 years ago by flesler

  • Status changed from assigned to closed
  • Resolution set to fixed
  • Component changed from fx to data

Applied at [6010-6012].

Note: See TracTickets for help on using tickets.