Modify ↓
Ticket #3355 (closed feature: fixed)
Add stopImmediatePropagation to event objects
| Reported by: | flesler | Owned by: | flesler |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.3 |
| Component: | event | Version: | 1.2.6 |
| Keywords: | stopimmediatepropagation | Cc: | john, joern, brandon, davidserduke |
| Blocking: | Blocked by: |
Attachments
-
stopImmediatePropagation[5843].diff
(1.6 KB) -
added by flesler 5 years ago.
- Uses the expando to modify the event objects, doesn't break old code.
Change History
Changed 5 years ago by flesler
-
attachment
stopImmediatePropagation[5843].diff
added
comment:3 Changed 5 years ago by joern
Good concept that fixes an annoying issue.
The patch could be improved a bit by replacing the "event[expando] == -1" bit with something more clear. Use a value that makes it obvious that its related to event propagation, not a magic number like -1.
comment:4 Changed 5 years ago by nathanhammon
Yes please. This is definitely something worth adding.
comment:5 Changed 5 years ago by flesler
The expando shouldn't be a number higher than 0, or could be misused by jQuery.data. Could be a string... but what for, it's just longer/heavier.
What would you propose Joern ?
Please follow the bug reporting guidlines and use jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.
Note: See
TracTickets for help on using
tickets.
Uses the expando to modify the event objects, doesn't break old code.