Bug Tracker

Ticket #3346 (closed enhancement: worksforme)

Opened 6 years ago

Last modified 4 years ago

empty and remove methods are too aggressive with event removal

Reported by: mike.helgeson Owned by: flesler
Priority: minor Milestone: 1.3
Component: core Version: 1.2.6
Keywords: empty remove Cc: mike.helgeson
Blocking: Blocked by:

Description

When these methods were modified to remove events, I found that a lot of code was broken. I am submitting a patch to have an additional argument to each of these methods to preserve events. API similar to "clone(true)"... the new calls are "remove(false)" and "remove(selector,false)" and "empty(false)" The "false" argument means DO NOT remove these events.

Attachments

remove_empty_patch.js Download (846 bytes) - added by mike.helgeson 6 years ago.

Change History

Changed 6 years ago by mike.helgeson

comment:1 Changed 6 years ago by flesler

  • Cc mike.helgeson added
  • need changed from Review to Patch
  • Status changed from new to assigned
  • Owner set to flesler

comment:2 Changed 5 years ago by mpaineau

I think that this enhancement is very important. Why not to include it in the 1.3.3 Milestone ? Thanks

comment:3 Changed 4 years ago by snover

  • Status changed from assigned to closed
  • Resolution set to worksforme

Use $.fn.detach.

Note: See TracTickets for help on using tickets.