Bug Tracker

Modify

Ticket #3331 (closed bug: fixed)

Opened 5 years ago

Last modified 4 years ago

curCSS() doesn't convert negative em/% values properly in IE

Reported by: jeff_themovie Owned by: flesler
Priority: major Milestone: 1.4
Component: core Version: 1.3.2
Keywords: Cc: jeff_themovie
Blocking: Blocked by:

Description

This is because line 920:

if ( !/\d+(px)?$/i.test( ret ) && /\d/.test( ret ) ) {

doesn't accept negative values. I suggest:

if ( !/-?\d+(px)?$/i.test( ret ) && /-?\d/.test( ret ) ) {

Attachments

curCSS.patch Download (555 bytes) - added by jeff_themovie 5 years ago.
testcase.html Download (1.1 KB) - added by jeff_themovie 4 years ago.
test case - notice what happens when the red box is hidden in IE

Change History

comment:1 Changed 5 years ago by flesler

  • Cc jeff_themovie added
  • need changed from Review to Patch
  • Status changed from new to assigned
  • Component changed from core to event
  • Owner set to flesler

Changed 5 years ago by jeff_themovie

comment:2 Changed 5 years ago by jeff_themovi

Patch attached. (The regex carets in the ticket description went missing for some reason...)

comment:3 Changed 5 years ago by jeff_themovi

Is there anything I should do to get the resolution process going?

Changed 4 years ago by jeff_themovie

test case - notice what happens when the red box is hidden in IE

comment:4 Changed 4 years ago by john

  • Version changed from 1.2.6 to 1.3.2
  • Component changed from event to core
  • Milestone changed from 1.3 to 1.4

comment:5 Changed 4 years ago by john

  • Status changed from assigned to closed
  • Resolution set to fixed

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.