Bug Tracker

Modify ↓

Ticket #3249 (closed enhancement: fixed)

Opened 5 years ago

Last modified 5 years ago

Slight change to jQuery.fn.serializeArray()

Reported by: nathanhammond Owned by: flesler
Priority: minor Milestone: 1.3
Component: ajax Version: 1.2.6
Keywords: Cc:
Blocking: Blocked by:

Description

I'm writing a plugin that would emulate the Form.elements array for any arbitrary element that is a descendant of a form. This new array would contain only those form elements that descend from it, in semantic order.

The benefits of this are right now being negated by one line in jQuery.fn.serializeArray() where it queries the nodeName to see if it is a form rather than querying the existence of the property.

I've attached a patch that would make that change.

Attachments

serialize.diff Download (400 bytes) - added by nathanhammond 5 years ago.
Patch

Change History

Changed 5 years ago by nathanhammond

Patch

comment:1 Changed 5 years ago by flesler

  • need changed from Review to Commit
  • Owner set to flesler
  • Status changed from new to assigned

Seems good to me. It's shorter, faster and what you need.

comment:2 Changed 5 years ago by flesler

  • Status changed from assigned to closed
  • Resolution set to fixed

Applied at [5826]. Passes all the tests.

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View ↑

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.