Bug Tracker

Modify ↓

Ticket #3248 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

Simple solution to Array.prototype.call + jQuery.makeArray conflict

Reported by: flesler Owned by: flesler
Priority: major Milestone: 1.3
Component: core Version: 1.2.6
Keywords: Cc: john,brandon,joern,davidserduke
Blocking: Blocked by:

Description

This is a possible fix to this annoying conflict.

Attachments

makeArray[5824].diff Download (1.6 KB) - added by flesler 5 years ago.

Change History

Changed 5 years ago by flesler

comment:1 Changed 5 years ago by flesler

  • Status changed from new to assigned

This will remove support for functions (regexps still supported) on makeArray. This passes all the tests on IE6, FF2, Opera 9.2, Opera 9.5, Safari 3. I assume the rest will follow.

I don't think it'll be an issue to drop this support as functions sent to the jQuery constructor are intercepted by init().

Shall I ?

comment:2 Changed 5 years ago by flesler

Related tickets (all rejected in the past by me): #3079, #3026, #3176, #3202, #3129.

comment:3 Changed 5 years ago by flesler

  • Status changed from assigned to closed
  • Resolution set to fixed

John approves :) Applied at [5825].

comment:4 Changed 5 years ago by flesler

Now that isFunction is much shorter and faster, re added support for functions on [5915].

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View ↑

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.