Bug Tracker

Modify ↓

Ticket #3194 (closed enhancement: invalid)

Opened 5 years ago

Last modified 3 years ago

Possible optimization for the selector module

Reported by: flesler Owned by: flesler
Priority: minor Milestone: 1.3
Component: selector Version: 1.2.6
Keywords: attr Cc:
Blocking: Blocked by:

Description

This reduces the code size and makes things more straight forward. But could be slower than the actual code...

Attachments

selector[5795].diff Download (600 bytes) - added by flesler 5 years ago.

Change History

Changed 5 years ago by flesler

comment:1 Changed 5 years ago by flesler

This adds a LOT of overhead :(

comment:2 Changed 5 years ago by joern

  • Status changed from new to closed
  • Resolution set to invalid

The performance overhead isn't worth the code improvement.

comment:3 Changed 5 years ago by joern

  • Status changed from closed to reopened
  • Resolution invalid deleted

The code to be removed is redundant with attr, maybe a refactoring is a better approach.

comment:4 Changed 5 years ago by flesler

I don't see why "redundant". Using attr() is the logical approach, it just adds too much overhead.

comment:5 Changed 3 years ago by dmethvin

  • Status changed from reopened to closed
  • Resolution set to invalid

This doesn't apply anymore since Sizzle was introduced.

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View ↑

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.