Bug Tracker

Modify ↓

Ticket #3162 (closed bug: invalid)

Opened 5 years ago

Last modified 4 years ago

Typo in clone function causes error in IE

Reported by: hjess Owned by: flesler
Priority: major Milestone: 1.3
Component: core Version: 1.2.6
Keywords: Cc:
Blocking: Blocked by:

Description

After "ret" is assigned as the result of "this.map", events are processed according to "this", rather than to "ret".

Attachments

jquery.diff Download (852 bytes) - added by hjess 5 years ago.
diff file

Change History

Changed 5 years ago by hjess

diff file

comment:1 Changed 5 years ago by flesler

  • need changed from Review to Test Case

Eh.. I'm not sure that's wrong. I really can't follow that piece of code completely.

Can you provide a test case that shows the situation where this causes an error ? Just a simple html file with the needed js.

Thanks

comment:2 Changed 5 years ago by zimbatm

After "ret" is assigned as the result of "this.map", events are processed according to "this", rather than to "ret".

Yes, because events are copied from this to the cloned elements. This is why this and it's childs must be visited.

comment:3 Changed 5 years ago by flesler

  • Owner set to flesler
  • Status changed from new to assigned

Will check this out more closely when I get some time.

comment:4 Changed 4 years ago by dmethvin

  • Status changed from assigned to closed
  • Resolution set to invalid

It looks correct as-is; "this" is the original elements and clone is the cloned elements.

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View ↑

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.