Skip to main content

Bug Tracker

Side navigation

#3107 closed enhancement (fixed)

Opened June 30, 2008 07:42PM UTC

Closed July 01, 2008 02:26AM UTC

Global Event Triggering Performance Enhancement

Reported by: mike.helgeson Owned by: flesler
Priority: minor Milestone: 1.3
Component: event Version: 1.2.6
Keywords: Cc:
Blocked by: Blocking:
Description

In my opinion the jquery core should not ever call jQuery("*") internally.

After investigating this unloading issue, I noticed another potential bottleneck with the global event triggering on line 1985 in 1.2.6 (uncompressed)

jQuery("*").add([window, document]).trigger(type, data);

I think this should be replaced by:

jQuery.each( jQuery.cache, function(){
   if ( this.events && this.events[type] )
      jQuery.trigger( type, data, this.handle.elem, true );
   });
Attachments (1)
Change History (2)

Changed July 01, 2008 02:26AM UTC by flesler comment:1

need: ReviewCommit
owner: → flesler
priority: trivialminor
status: newassigned

I modified the code a bit, it wasn't right.

Changed July 01, 2008 02:26AM UTC by flesler comment:2

resolution: → fixed
status: assignedclosed

Applied at [5757]. Thanks.