Ticket #3082 (closed enhancement: fixed)
Speed improvements for jQuery.css("width"/"height") in combination of dimensions.js
| Reported by: | paul | Owned by: | john |
|---|---|---|---|
| Priority: | major | Milestone: | 1.3.2 |
| Component: | dimensions | Version: | 1.3.1 |
| Keywords: | Cc: | ||
| Blocking: | Blocked by: |
Description
After many tests, the functions outerWidth and outerHeight in dimensions.js, which make calls to innerHeight/innerWidth, and therefore to jQuery.fn.width or jQuery.fn.height, are the main bottleneck of many core interaction modules in jQuery UI.
After investigating, I'm seeing that there's a lot of room for improvement especially in jQuery.css (i.e. the :visible check is quite heavy), and I would like to see if there's anybody who can come up specifically with improvements for
outerWidth outrHeight
Attachments
-
dimension_patch.js
(3.3 KB) -
added by mike.helgeson 4 years ago.
- updated for 1.3.x
-
dimension_pseudo_patch.js
(3.3 KB) -
added by mike.helgeson 4 years ago.
- tried to make it more patch ready…
-
3082.patch
(2.7 KB) -
added by john 4 years ago.
- Went through and included the best concepts from the previous patches.
Change History
comment:3 Changed 4 years ago by john
- Owner changed from brandon to john
- Version changed from 1.2.6 to 1.3.1
- Milestone changed from 1.3 to 1.3.2
Changed 4 years ago by mike.helgeson
-
attachment
dimension_pseudo_patch.js
added
tried to make it more patch ready...
Changed 4 years ago by john
-
attachment
3082.patch
added
Went through and included the best concepts from the previous patches.
Please follow the bug reporting guidlines and use jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.
dimension_patch.js can be included after jquery to test. A new jQuery function is added called $.size and some others overwritten. I guess it needs to be run through the test suite and debated and probably improved some more... but its a start.