Side navigation
#3048 closed bug (fixed)
Opened June 16, 2008 12:15PM UTC
Closed June 17, 2008 08:13PM UTC
Last modified August 08, 2008 05:42PM UTC
QUnit/testrunner.js fails when error message contains XML-interpreted characters
| Reported by: | bdumon | Owned by: | flesler |
|---|---|---|---|
| Priority: | minor | Milestone: | |
| Component: | qunit | Version: | |
| Keywords: | qunit | Cc: | |
| Blocked by: | Blocking: |
Description
When a test throws an exception and the exception message contains characters with an XML-meaning, the testrunner will fail with a SAXParseException.
For example, I've got a test which throws an exception whose message is like this:
The element type "input" must be terminated by the matching end-tag "</input>"
which will in turn cause an error like:
test_core: Wrapped java.lang.RuntimeException: org.xml.sax.SAXParseException: The element type "wrap" must be terminated by the matching end-tag "</wrap>". (file:/home/bruno/projects/kauri/trunk/modules/kauri-forms/kauri-forms-framework/../kauri-forms-jquery/src/main/kauri/js/testrunner.js#146)
The solution is either to escape any special characters in the message string, or to not interprete it as HTML.
In the attached patch, I take the latter approach.
Attachments (1)
Change History (3)
Changed June 17, 2008 08:12PM UTC by comment:1
| need: | Review → Commit |
|---|---|
| owner: | joern → flesler |
| status: | new → assigned |
Changed June 17, 2008 08:13PM UTC by comment:2
| resolution: | → fixed |
|---|---|
| status: | assigned → closed |
Fixed at [5730].
I actually added the same modification before checking your patch.
I modified the "informal" version of qunit, I'll let Joern know about this change.
Thanks for reporting.
Changed August 08, 2008 05:42PM UTC by comment:3
Now also part of QUnit itself, see [5812].