Side navigation
#2969 closed bug (wontfix)
Opened June 02, 2008 04:28PM UTC
Closed September 14, 2009 07:26PM UTC
Add failsafe check to jQuery.ready()
| Reported by: | sun | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 1.3 |
| Component: | event | Version: | 1.2.5 |
| Keywords: | ready, readylist, readylist.push | Cc: | sun |
| Blocked by: | Blocking: |
Description
I just spent plenty of time to debug why all of my JavaScript was broken and finally found out that a single function name inside of document.ready(example_function()) was not callable. Would a simple patch as in http://sun.pastebin.us/pastebin.php?diff=d64e38491 (or similar) be accepted?
Attachments (1)
Change History (5)
Changed June 04, 2008 04:00PM UTC by comment:1
Changed June 04, 2008 04:01PM UTC by comment:2
| component: | core → event |
|---|
Changed May 16, 2009 01:55AM UTC by comment:3
This seems like the wrong way to address the problem. The proposed patch silently ignores any argument that isn't a function. The current behavior throws an error, so it's at least giving some hint that there is a problem in the code.
Changed May 16, 2009 02:11AM UTC by comment:4
Please close this issue. (I can't see how/where I could do that)
I was dumb, and jQuery improved over time.
Changed September 14, 2009 07:26PM UTC by comment:5
| cc: | → sun |
|---|---|
| resolution: | → wontfix |
| status: | new → closed |
I think it's easy to realize you made a mistake if all fails, than having one single function not executing that you don't know why.