Ticket #2947 (closed bug: fixed)
Event: altKey not set
| Reported by: | ivan | Owned by: | flesler |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.3 |
| Component: | event | Version: | 1.2.5 |
| Keywords: | Cc: | ||
| Blocking: | Blocked by: |
Description
The altKey field is not set in the Event object.
Attachments
-
event.js.patch
(671 bytes) -
added by ivan 5 years ago.
- Patch
Change History
Changed 5 years ago by ivan
-
attachment
event.js.patch
added
comment:1 Changed 5 years ago by flesler
- need changed from Review to Test Case
- Owner set to flesler
- Status changed from new to assigned
The patch is invalid, it won't add altKey.
Can you provide a test case where we can see the altKey missing ?
Thanks
comment:2 Changed 5 years ago by nostrademons
I'm getting this too. Test case:
http://dev.diffle.com/jonathan/public/jquery_bug_2947/
Ivan's patch is valid. The problem is an off-by-1 error when it's looping through the fields: it starts at props.length (which is an invalid index), and ends at i = 1. When i = 0, the loop condition is false and so it doesn't perform the iteration that would assign altKey.
comment:3 Changed 5 years ago by ivan
Sorry I haven't been around. Thanks nostrademons for providing the test case and explanation.
comment:4 Changed 5 years ago by flesler
- Status changed from assigned to closed
- Resolution set to fixed
Right, got it now. I actually fixed this some weeks ago, I thought it made it into 1.2.6 but now I realize it didn't :(
Could you check this with the version in the trunk ?
Please reopen if that one still fails.
Thanks.
Please follow the bug reporting guidlines and use jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.
Patch