Bug Tracker

#2947 closed bug (fixed)

Opened May 28, 2008 02:44PM UTC

Closed June 11, 2008 10:37PM UTC

Last modified August 05, 2008 02:49PM UTC

Event: altKey not set

Reported by: ivan Owned by: flesler
Priority: minor Milestone: 1.3
Component: event Version: 1.2.5
Keywords: Cc:
Blocked by: Blocking:
Description

The altKey field is not set in the Event object.

Attachments (1)
  • event.js.patch (0.7 KB) - added by ivan May 28, 2008 02:45PM UTC.

    Patch

Change History (5)

Changed May 28, 2008 08:29PM UTC by flesler comment:1

need: Review → Test Case
owner: → flesler
status: new → assigned

The patch is invalid, it won't add altKey.

Can you provide a test case where we can see the altKey missing ?

Thanks

Changed May 31, 2008 08:53PM UTC by nostrademons comment:2

I'm getting this too. Test case:

http://dev.diffle.com/jonathan/public/jquery_bug_2947/

Ivan's patch is valid. The problem is an off-by-1 error when it's looping through the fields: it starts at props.length (which is an invalid index), and ends at i = 1. When i = 0, the loop condition is false and so it doesn't perform the iteration that would assign altKey.

Changed June 09, 2008 10:58AM UTC by ivan comment:3

Sorry I haven't been around. Thanks nostrademons for providing the test case and explanation.

Changed June 11, 2008 10:37PM UTC by flesler comment:4

resolution: → fixed
status: assigned → closed

Right, got it now. I actually fixed this some weeks ago, I thought it made it into 1.2.6 but now I realize it didn't :(

Could you check this with the version in the trunk ?

Please reopen if that one still fails.

Thanks.

Changed August 05, 2008 02:49PM UTC by flesler comment:5

This was fixed on [5707].