Bug Tracker

Modify ↓

Ticket #2857 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

[ui.dialog] Exceptions thrown if positioning in iframe

Reported by: tyler Owned by: paul
Priority: critical Milestone: 1.2.4
Component: ui Version: 1.2.3
Keywords: Cc:
Blocking: Blocked by:

Description

If you're in a less-than-stellar browser (Safari 2, IE6) that has certain security restraints on trying to set the position of "top" from inside a frame (besides it being an object) currently dialog.position() will thrown an exception that will break the entire page.

The attached patch will safely set "top" in Firefox and such, and have certain fallback behavior for browsers that have issues with iframes trying set "top".

Attachments

ui.dialog.js.patch Download (2.2 KB) - added by tyler 5 years ago.
this one's for real

Change History

Changed 5 years ago by tyler

this one's for real

comment:1 Changed 5 years ago by tyler

Ugh, talk about overengineering, the biggest problem is that it's reassigning the top variable >_<

comment:2 Changed 5 years ago by scott.gonzal

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in [5595]. Thanks.

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View ↑

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.