Side navigation
#2857 closed bug (fixed)
Opened May 13, 2008 08:52PM UTC
Closed May 14, 2008 04:43PM UTC
[ui.dialog] Exceptions thrown if positioning in iframe
Reported by: | tyler | Owned by: | paul |
---|---|---|---|
Priority: | critical | Milestone: | 1.2.4 |
Component: | ui | Version: | 1.2.3 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
If you're in a less-than-stellar browser (Safari 2, IE6) that has certain security restraints on trying to set the position of "top" from inside a frame (besides it being an object) currently dialog.position() will thrown an exception that will break the entire page.
The attached patch will safely set "top" in Firefox and such, and have certain fallback behavior for browsers that have issues with iframes trying set "top".
Ugh, talk about overengineering, the biggest problem is that it's reassigning the top variable >_<