Bug Tracker

Modify ↓

Ticket #2802 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

jQuery.curCSS failes in Safari 2.x

Reported by: ebartels Owned by:
Priority: undecided Milestone: 1.2.4
Component: core Version: 1.2.3
Keywords: safari getComputedStyle type error Cc:
Blocking: Blocked by:

Description

changeset [5274] introduces an error in Safari 2.x where calls to jQuery.curCSS will fail with a type error

Apparently, Safari 2 doesn't like the use of getComputedStyle function, introduced on line 615, in place of the full document.defaultView.getComputedStyle

Attachments

ticket2802_safari_curCSS.diff Download (704 bytes) - added by ebartels 5 years ago.

Change History

Changed 5 years ago by ebartels

comment:1 Changed 5 years ago by ebartels

The patch should still take advantage of the optimization from [5274], but when actually making the function call, it uses the full version to keep Safari happy.

comment:2 Changed 5 years ago by flesler

  • need changed from Review to Test Case

I don't see how the optimization is kept. This needs some testing, but if fails on Safari 2, then we could have a special case where getComputedStyle is a function, that calls internally to document.defaultView.....

Only for Safari 2.x

comment:3 Changed 5 years ago by flesler

  • Status changed from new to closed
  • Resolution set to fixed

This should be fixed now ([5609]). Could you confirm this ? I don't have Safari 2.

Reopen if it still fails.

comment:4 Changed 5 years ago by klaus

Fixed - that was just in time for me. Thanks Ariel :-)

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View ↑

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.