Modify ↓
Ticket #2620 (closed bug: fixed)
event.fix() possible null dereference
| Reported by: | jacob | Owned by: | brandon |
|---|---|---|---|
| Priority: | trivial | Milestone: | 1.4 |
| Component: | event | Version: | 1.2.3 |
| Keywords: | Cc: | ||
| Blocking: | Blocked by: |
Description
event.fix() does some checks for document.documentElement being not null before it dereferences them, but not enough.
Attachments
-
event-2620.patch
(860 bytes) -
added by jacob 5 years ago.
- don't dereference doc if it's null
Change History
Changed 5 years ago by jacob
-
attachment
event-2620.patch
added
comment:1 Changed 5 years ago by davidserduke
Are you actually seeing a bug because of this behavior in some browser or is this written up through a code review?
comment:3 Changed 4 years ago by dmethvin
Since doc.scrollLeft is guarded by a check for doc, it does seem like doc.clientLeft should be done the same way. Either that or the check in front of doc.scrollLeft is extraneous. It would help to have a test case though. Is document.documentElement null in quirks mode?
Please follow the bug reporting guidlines and use jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.
Note: See
TracTickets for help on using
tickets.
don't dereference doc if it's null