jQuery(html) breaks with HTML comments in Firefox 2

[scott.gonzalez]

var html = '<div>foo</div><!-- bar -->';

// throws an error
$(html).hide();

// works fine
$('<div/>').html(html).children().hide();

[davidserduke]

It appears that the html comment is being created as a node in the jQuery object as expected. But when the :visible call is made on it, the jQuery.css is failing. I'd guess a check to see if the node is not appropriate in jQuery.css() would fix this.

[flesler]

This seems to require checks on many places like $.filter, $.multiFilter and pretty much every DOM method. Most don't do any check, or they check for textNodes.

I'm not sure it's worthy. It's probably better to advice you to do:

$(html).filter('[nodeType=1]').hide();
or
$(html).not('[nodeType=8]').hide();

I'm closing as wontfix, reopen if you have something else to say.

[scott.gonzal]

There are already a few methods that specifically check for comment nodes to make sure they get skipped. I think the most relevant check is in jQuery.merge() which ensures that comment nodes don't get merged in. A similar check could be added to jQuery.clean() to make sure that comment nodes are stripped before calling jQuery.makeArray().

[flesler]

This should fix this, but breaks 3 tests. I'll postpone this for now.. we have more critical tickets and we're close to a release.

[anonymous]

hello

[SlexAxton]

Is this still something anyone cares about?

[trac-o-bot]

Automatically closed due to 14 days of inactivity.

[anonymous]

This is causing problems for me. Please fix.

[snover]

We don’t support Firefox 2 any more. This will never be fixed.