Ticket #2513 (closed enhancement: invalid)
Accordion: classNames should be default
| Reported by: | neojp | Owned by: | joern |
|---|---|---|---|
| Priority: | trivial | Milestone: | |
| Component: | ui | Version: | |
| Keywords: | Cc: | ||
| Blocking: | Blocked by: |
Description
Theme related classNames should be added to the accordions by default.
$(container).addClass("ui-accordion-container ui-accordion");
// add classNames and spans to header
options.headers.addClass('ui-accordion-link').prepend('<span class="ui-accordion-left"></span>').append('<span class="ui-accordion-right"></span>');
Attachments
Change History
Changed 5 years ago by neojp
-
attachment
ui.accordion_theme.diff
added
comment:1 Changed 5 years ago by neojp
Talking about a theming issue, headers should be relative positioned.
ul.ui-accordion-container li a.ui-accordion-link { position: relative }
Changed 5 years ago by neojp
-
attachment
flora.accordion.diff
added
accordion flora theme, position relative added to headers
comment:4 Changed 5 years ago by neojp
postion:relative; is not that necessary if you don't append the header spans. If they are not positioned inside a reltive they will appear on the top right corner of the document.
Regarding this,
$(container).addClass("ui-accordion-container ui-accordion");
I'm not sure why the accordion plugin uses 2 different classNames for the same element, since it never uses one. I think we could get rid of one and change the css styles to match the className choosen.
Please follow the bug reporting guidlines and use jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

UI Accordion: add classnames, and spans for themes