Bug Tracker

Modify

Ticket #2513 (closed enhancement: invalid)

Opened 6 years ago

Last modified 6 years ago

Accordion: classNames should be default

Reported by: neojp Owned by: joern
Priority: trivial Milestone:
Component: ui Version:
Keywords: Cc:
Blocking: Blocked by:

Description

Theme related classNames should be added to the accordions by default.

$(container).addClass("ui-accordion-container ui-accordion");
// add classNames and spans to header
options.headers.addClass('ui-accordion-link').prepend('<span class="ui-accordion-left"></span>').append('<span class="ui-accordion-right"></span>');

Attachments

ui.accordion_theme.diff Download (996 bytes) - added by neojp 6 years ago.
UI Accordion: add classnames, and spans for themes
flora.accordion.diff Download (1.1 KB) - added by neojp 6 years ago.
accordion flora theme, position relative added to headers

Change History

Changed 6 years ago by neojp

UI Accordion: add classnames, and spans for themes

comment:1 Changed 6 years ago by neojp

Talking about a theming issue, headers should be relative positioned.

ul.ui-accordion-container li a.ui-accordion-link { position: relative }

Changed 6 years ago by neojp

accordion flora theme, position relative added to headers

comment:2 Changed 6 years ago by paul

  • Owner changed from paul to joern

comment:3 Changed 6 years ago by scott.gonzal

Why are both .ui-accordion and .ui-accordion-container needed if they're applied to the same element?

Also, why is relative positioning required? I'm asking because this was actually removed in [4420] to fix #2127.

comment:4 Changed 6 years ago by neojp

postion:relative; is not that necessary if you don't append the header spans. If they are not positioned inside a reltive they will appear on the top right corner of the document.

Regarding this,

$(container).addClass("ui-accordion-container ui-accordion");

I'm not sure why the accordion plugin uses 2 different classNames for the same element, since it never uses one. I think we could get rid of one and change the css styles to match the className choosen.

comment:5 Changed 6 years ago by joern

  • Status changed from new to closed
  • Resolution set to invalid

The second class got removed, other issues are now on the UI bugtracker.

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.