Bug Tracker

Ticket #2418 (closed bug: fixed)

Opened 7 years ago

Last modified 4 years ago

Safari/WebKit version is checked incorrectly, causing null values

Reported by: mcrawford620 Owned by:
Priority: trivial Milestone: 1.2.4
Component: core Version: 1.2.3
Keywords: safari, webkit Cc:
Blocking: Blocked by:

Description

On line 1353, there is the test: var chars = jQuery.browser.safari && parseInt(jQuery.browser.version) < 417

The bug you're working around was fixed in WebKit build 417.5. See:  http://trac.webkit.org/projects/webkit/browser/tags/JavaScriptCore-418/JavaScriptCore/ChangeLog

So I think the line 1353 test needs to be something like: jQuery.browser.safari && jQuery.browser.version < 417.5 but I don't know exactly how the version comparison works (int, float, etc.).

Yes, I was forced to test my website on a WebKit build 417.2, and the jQuery code bombed. I don't have that build myself, it's on my client's machine, so I can't make a test case or anything like that. For our site, I changed the line to read parseInt(jQuery.browser.version) < 418 which made our client happy, but I guess that's not technically correct either.

Change History

comment:1 Changed 4 years ago by dmethvin

  • Status changed from new to closed
  • Resolution set to fixed

Browser check has been removed.

Note: See TracTickets for help on using tickets.