Bug Tracker

Modify

Ticket #2360 (closed bug: fixed)

Opened 5 years ago

Last modified 15 months ago

[treeview] Branches with checkboxes

Reported by: morrijr Owned by: joern
Priority: major Milestone:
Component: plugin Version:
Keywords: treeview Cc:
Blocking: Blocked by:

Description

Hi Jörn

The problem I've got is that I need to be able to have a checkbox on each branch/node, but clicking the checkbox of a branch in addition to toggling the checkbox expands/collapses the branch.

Can you help? I can't see what's causing this. This is a regression from 1.3.

Thanks,

J.

Attachments

experimental.zip Download (44.5 KB) - added by morrijr 5 years ago.
Test case

Change History

Changed 5 years ago by morrijr

Test case

comment:1 Changed 5 years ago by morrijr

The change that is causing this is in the applyClasses function.

From (1.3)

this.filter(":has(>ul):not(:has(>a))").find(">span").click(function(event) {
    if ( this == event.target ) {
        toggler.apply($(this).next());
    }
}).add( $("a", this) ).hoverClass();

to (1.4)

this.filter(":has(>ul):not(:has(>a))").find(">span").click(function(event) {
    toggler.apply($(this).next());
}).add( $("a", this) ).hoverClass();

Was there a reason this if was removed?

comment:2 Changed 5 years ago by joern

  • Owner set to joern
  • Summary changed from [TreeView] Branches with checkboxes to [treeview] Branches with checkboxes
  • need changed from Review to Commit
  • Version 1.2.3 deleted
  • Milestone 1.2.4 deleted
  • Keywords branch checkbox removed

Note: Add comment why the check is necessary.

comment:3 Changed 5 years ago by joern

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in [5100].

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.