Bug Tracker

#2101 closed bug (fixed)

Opened December 31, 2007 05:36PM UTC

Closed January 20, 2008 02:23PM UTC

Minor build script issues

Reported by: emartin24 Owned by:
Priority: minor Milestone: 1.2.2
Component: build Version: 1.2.1
Keywords: build, version, pack, dist Cc:
Blocked by: Blocking:
Description

I found a couple of minor issues in the build scripts.

1) In version.js, the @VERSION replace will only happen for the first occurence. To make it do a global replace, the call needs to be changed to:

readFile(file).replace(RegExp("@VERSION", "g")

I'm not sure if this was intentional, but if it is not a global replace, the @VERSION, currently on line 104, will not be replaced.

2) In pack.js, if the outFile is not specified as an argument, the filename will be jquerypack.js instead of jquery.pack.js. A period needs to be added to "pack.js"

Patches included.

Attachments (1)
  • build-version-pack.patch (0.9 KB) - added by emartin24 December 31, 2007 05:38PM UTC.

    version.js fix for global @VERSION replacement and pack.js fix for outFile filename

Change History (3)

Changed January 14, 2008 07:14PM UTC by john comment:1

component: core → build
resolution: → fixed
status: new → closed

Fixed in SVN rev [4442]. The @VERSION stuff is in the build file now.

Changed January 15, 2008 05:06PM UTC by emartin24 comment:2

resolution: fixed
status: closed → reopened

It looks like the global @VERSION replacement works correctly when building with make, but not ant. The fix I suggested for version.js will correct that.

-Eric

Changed January 20, 2008 02:23PM UTC by joern comment:3

resolution: → fixed
status: reopened → closed

Fixed in [4486].