Ticket #2101 (closed bug: fixed)
Minor build script issues
| Reported by: | emartin24 | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.2.2 |
| Component: | build | Version: | 1.2.1 |
| Keywords: | build, version, pack, dist | Cc: | |
| Blocking: | Blocked by: |
Description
I found a couple of minor issues in the build scripts.
1) In version.js, the @VERSION replace will only happen for the first occurence. To make it do a global replace, the call needs to be changed to: readFile(file).replace(RegExp("@VERSION", "g") I'm not sure if this was intentional, but if it is not a global replace, the @VERSION, currently on line 104, will not be replaced.
2) In pack.js, if the outFile is not specified as an argument, the filename will be jquerypack.js instead of jquery.pack.js. A period needs to be added to "pack.js"
Patches included.
Attachments
-
build-version-pack.patch
(902 bytes) -
added by emartin24 5 years ago.
- version.js fix for global @VERSION replacement and pack.js fix for outFile filename
Change History
Changed 5 years ago by emartin24
-
attachment
build-version-pack.patch
added
comment:1 Changed 5 years ago by john
- Status changed from new to closed
- Resolution set to fixed
- Component changed from core to build
Fixed in SVN rev [4442]. The @VERSION stuff is in the build file now.
Please follow the bug reporting guidlines and use jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.
version.js fix for global @VERSION replacement and pack.js fix for outFile filename