Droppable accept function improvement

Reported by:	mnichols	Owned by:	rworth
Priority:	major	Milestone:	1.2.2
Component:	ui	Version:	1.2.1
Keywords:		Cc:
Blocked by:		Blocking:

Description

I am commonly needing to get the droppable element being targeted during an 'accept' callback to determine if the draggable signature is acceptable against the droppable element.

There isn't an easy way to get the droppable instance during this callback, so I changed draggable and droppable to use 'call' while passing in the droppable instance to force 'this' to always be the droppable being targeted during the accept callback.

Really, the 'ui' object should be getting passed in to this callback just like the other options to be consistent.

Please see attached patches or consider changing the method signature of this callback ... the function callback seems to have been an afterthought.

Attachments (4)

droppable.accept.this.patch (0.7 KB) - added by m0n5t3r January 21, 2008 05:00PM UTC.

droppable accept hack
uidraggable121607.patch (1.2 KB) - added by mnichols December 17, 2007 06:57AM UTC.

Draggable using 'call' for accept callback
uidroppable-pass.ui.to.accept.patch (2.4 KB) - added by mnichols January 05, 2008 09:49AM UTC.

Patch successfully passes ui to the accept function of droppable
uidroppable121607.patch (2.2 KB) - added by mnichols December 17, 2007 06:57AM UTC.

Droppable invoking using 'call' on accept callback

Change History (9)

Changed December 17, 2007 07:18AM UTC by mnichols comment:1

My draggable patch has a small error...it is passing the draggable instead of the draggable.element as other parts do.

Really, the documentation is wrong when it says that the draggable is passed to the accept callback since in fact the draggable.element is being passed.

Changed December 18, 2007 02:34AM UTC by rworth comment:2

owner:	→ rworth
status:	new → assigned

Changed January 05, 2008 09:50AM UTC by mnichols comment:3

Due to the complete rewrite of droppables recently, the first two patches are stale.

I have created a new patch that allows passing the 'ui' object from droppable into the accept function. This gives developer better options for determining if an draggable should be accepted based on criteria found in the target droppable.

Please see attached ' uidroppable-pass.ui.to.accept.patch '

and disregard the previous patches....

Mike

Changed January 08, 2008 05:25AM UTC by mnichols comment:4

I submitted #2122 that has this patch and a fix to the most recent trunk.

I'd recommend disregarding this patch to get the fix.

Mike

Changed January 21, 2008 05:02PM UTC by m0n5t3r comment:5

I think the above patch is a more elegant approach to passing the ui object as

this

to the accept function

Changed January 21, 2008 09:52PM UTC by mnichols comment:6

does this work on the rewrite that was done on the trunk?

Changed January 23, 2008 03:27PM UTC by m0n5t3r comment:7

it's made against r4501, should apply cleanly to current trunk (the changes that have occurred since then are fn API changes, the ui part is unchanged)

Changed January 26, 2008 06:16PM UTC by mnichols comment:8

If I understand your patch, it seems your patch is passing the droppable (not ui) to be

 this

The patch I submitted in #2122 passes the ui object as an arg the same as the other method calls. This is more intuitive I think than requiring the dev to back into the

ui

object thru

this

Changed October 24, 2010 04:47PM UTC by rwaldron comment:9

resolution:	→ invalid
status:	assigned → closed

UI bugs should be reported to: http://dev.jqueryui.com/

Side navigation

#2063 closed enhancement (invalid)