Bug Tracker

Modify ↓

Ticket #1997 (closed bug: worksforme)

Opened 5 years ago

Last modified 5 years ago

Dialog position relative to page length and not window height.

Reported by: Xichekolas Owned by: rworth
Priority: major Milestone: 1.2.2
Component: ui Version: 1.2.1
Keywords: ui, dialog, position Cc:
Blocking: Blocked by:

Description

In ui.dialog.js, several of the position options (lines 113-134) determine the top offset of the dialog based on math involving $(window).height(). This is the actual length of the page, not the height of the viewable area of the page.

The result is that on really long pages, this value is huge and the dialog is opened way below where the user is currently viewing. It seems like the open fails, but you just have to scroll down quite a bit to find it. Is there a way to get the height of the viewable area rather than what amounts to the length of the entire page?

Change History

comment:1 Changed 5 years ago by rworth

  • Owner set to rworth
  • Status changed from new to assigned

comment:2 Changed 5 years ago by rworth

  • Status changed from assigned to closed
  • Resolution set to worksforme

$(window).height() is correct here. You must be thinking of $(document).height(). Tested latest (rev4061) in IE and FF. Worksforme.

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View ↑

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.