Bug Tracker

Modify ↓

Ticket #196 (closed bug: fixed)

Opened 7 years ago

Last modified 4 years ago

Please dont shaddow XMLHttpRequest

Reported by: daniel.doubleday@… Owned by:
Priority: undecided Milestone:
Component: ajax Version:
Keywords: Cc:
Blocking: Blocked by:

Description (last modified by dmethvin) (diff)

This breaks other libraries which distinguish between ie and other via "is defined" checks such as DWR and others.

Please use a factory method instead.

I know that this will break backward compatability but I think the "I know that I'm not alone" approach is worth it.

Change History

comment:1 Changed 7 years ago by joern

  • Status changed from new to closed
  • Resolution set to worksforme

If we remove the shadowed XMLHttpRequest, I'd have to remove the fixed event object etc. pp. That can't be the right solution either, therefore I close this report.

comment:2 Changed 7 years ago by john

  • Status changed from closed to reopened
  • Resolution worksforme deleted

I still think we should consider this - this is one area in which we do introduce something into the global namespace, when we really shouldn't.

comment:3 Changed 4 years ago by dmethvin

  • Status changed from reopened to closed
  • Description modified (diff)
  • Type set to bug
  • Component set to ajax
  • Priority set to blocker
  • need set to Review
  • Resolution set to fixed

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View ↑

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.