Ticket #1887 (closed bug: fixed)
Sortables -- bad options do not fail gracefully, explode
| Reported by: | Bradley | Owned by: | rworth |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.2.2 |
| Component: | ui | Version: | 1.2.1 |
| Keywords: | ui, sortable, draggable | Cc: | |
| Blocking: | Blocked by: |
Description
Some sortable options do not fail gracefully/silently if passed an argument of the wrong type. For instance, the update option expects a function. If you pass a string by accident, it should fail gracefully but rather goes into an infinite loop of errors.
Infinite loop of errors
$("#list li").sortable({
update: 'oops its a string'
});
A simple conditional could stop this effect:
Pseudocode
if (typeof theargument != 'function') { fail gracefully }
I've seen this with sortables, specifically the stop and update options, but I'm sure it's in other areas such as draggables also. While it does take human error to trigger it, human error should not make your browser explode.
Change History
Please follow the bug reporting guidlines and use jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.
