More powerful toggleClass()

[dimi]

A lot of times you need to add/remove a class to an element based on a boolean. toggleClass() should take an optional second parameter that would control if the toggle will add or remove the class.

The added complexity would be absolutely minimal (a few more characters), but it would be really useful.

[brandon]

Could you provide a few examples of how this will improve your code?

[genezys]

I agree with this one, it would be nice to be able to add/remove a class based on a boolean value.

Here are some examples:

"item" is an object
"$item" is the jQuery object representing "item"
I want to add the class "Selected" to the UI when the object has the attribute "selected".

First version, very verbose

if( item.selected )
{
  $item.addClass("Selected");
}
else
{
  $item.removeClass("Selected");
}

Second version, less verbose but less readable

var toggleClass = ( item.selected ? $.fn.addClass : $.fn.removeClass );
toggleClass.call($item, "Selected");

Third version, what would be nice

$item.toggleClass("Selected", item.selected);

[ecentinela]

An why not?

$item[item.selected ? 'removeClass' : 'addClass']("Selected");

[flesler]

So.. what do we do about this ?

[genezys]

Here are attached the modification to the core and tests to fix this bug.

[flesler]

This is not a bug, it's an enhancement. I think this is doable, will handle it asap.

[flesler]

Added at [6000].