curCSS does not validate returned value of getComputedStyle

[lmnt]

in line 729 of jquery 1.2.1:

ret = prop == "display" && swap[stack.length-1] != null ?
    "none" :
    document.defaultView.getComputedStyle(elem,null).getPropertyValue(prop) || "";

this could probably be done more elegantly but for my purposes it's suited.

will fail if getComputedStyle() does not return as expected (such as when working with iframes). This is easily remedied by adding a simple check:

ret = prop == "display" && swap[stack.length-1] != null ?
    "none" :
    (document.defaultView.getComputedStyle(elem,null) ? 
        document.defaultView.getComputedStyle(elem,null).getPropertyValue(prop) || "" : "" 
    );

[danielnashnz]

You got there before me! Shouldn't the code be:

ret = (prop == "display" && swap[stack.length-1] != null) ? "none" : (document.defaultView.getComputedStyle(elem,null) != null) ? document.defaultView.getComputedStyle(elem,null).getPropertyValue(prop) : "";

??

[mc_funkster]

I vote for this bug to get fixed (soon) with danielnashnz' fix.

Imnt is missing a ')' after the check for a null computed style

[geoffreyk]

I just ran headlong into this bug as well with an iframe. Seems that the fix is simple and localized. Just trying to pump this bug up a bit. (I hate to run with a patched version of jquery)

[davidserduke]

This appears like it could be the same as #1779 which was fixed.

[geoffreyk]

I don't think so. I just applied the changes from 1779, and that doesn't fix this problem.

this code does seem to fix the problem, though I don't know how this would affect #1779

				ret = (prop == "display" && swap[stack.length-1] != null) ? 
					"none" : 
					(document.defaultView.getComputedStyle(elem,null) != null) ? 
						document.defaultView.getComputedStyle(elem,null).getPropertyValue(prop) : "";

[davidserduke]

Do you have a test case I could use that displays the problem?

[davidserduke]

If you applied the patch to 1.2.1 then it definitely won't work. Some other changes have been made to the function in SVN that are required.

I think this is fixed in SVN and am going to mark it as such. If you have a test case that doesn't work please attach it and reopen the bug.

So fixed in [3644].