Bug Tracker

#1629 closed enhancement (fixed)

Opened September 16, 2007 02:34PM UTC

Closed December 11, 2007 04:44AM UTC

.width() and .height() flickering and inefficiency

Reported by: arrix Owned by:
Priority: major Milestone: 1.2.2
Component: core Version: 1.2
Keywords: Cc:
Blocked by: Blocking:
Description

.width() and .height() are probably the most useful functions in complex UI programming. But there are some annoying defects

1. resetting borderWidth/Height and paddingWidth/Height causes flickers. see #1613

2. changing the css position of the parent elements in certain cases cause undesired side effects. e.g. #1415

3. cloning invisible elements could be inefficient, especially when the element has many descendants

for # 1, I suggest we minus the padding/border from client/offsetWdith/Height.

for # 2, I'm not sure why the position:relative is needed. if it were to gain layout in IE, then I would suggest zoom:1

for # 3, I suggest we move the element off screen and make it visible instead of cloning.

Attachments (3)
  • 1629.diff (2.0 KB) - added by davidserduke December 10, 2007 10:36PM UTC.

    new proposed patch

  • core.diff (1.9 KB) - added by brandon December 09, 2007 01:03AM UTC.

    A possible patch

  • jquery_test.html (2.7 KB) - added by davidserduke December 10, 2007 10:33PM UTC.

    test case demo'ing an error in Opera that this patch reveals

Change History (3)

Changed September 27, 2007 03:34PM UTC by brandon comment:1

milestone: 1.2.1 → 1.2.2

Changed December 09, 2007 01:04AM UTC by brandon comment:2

This passes the test suite except in Opera where a couple of fx tests fail but if you run the failed tests individually, they pass. I haven't done much testing outside the test suite.

Changed December 11, 2007 04:44AM UTC by brandon comment:3

resolution: → fixed
status: new → closed

Fixed in Rev [4100].