Bug Tracker

Modify

Ticket #1604 (closed bug: fixed)

Opened 6 years ago

Last modified 15 months ago

IE6 incorrect value of jQuery(window).height()

Reported by: Q-Zma Owned by:
Priority: major Milestone: 1.2.2
Component: core Version: 1.2
Keywords: Cc:
Blocking: Blocked by:

Description

In IE6 incorrect value returned, instead of min value it returns max value. Patch attached.

Attachments

fix.patch Download (568 bytes) - added by Q-Zma 6 years ago.
patch which fixes that micro bug

Change History

Changed 6 years ago by Q-Zma

patch which fixes that micro bug

comment:1 Changed 6 years ago by john

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from 1.2 to 1.2.1

This should be fixed in SVN, by brandon.

comment:2 Changed 6 years ago by arrix

  • Status changed from closed to reopened
  • Resolution fixed deleted

The latest svn version still has some problems.

See new $(window).height() functionality in the dev list.

Here is another patch.

Index: E:/zm/jquery/jquery/src/core.js
===================================================================
--- E:/zm/jquery/jquery/src/core.js	(revision 3329)
+++ E:/zm/jquery/jquery/src/core.js	(working copy)
@@ -1115,8 +1115,8 @@
 	
 	jQuery.fn[ n ] = function(h) {
 		return this[0] == window ?
-			jQuery.browser.safari && self["inner" + name] ||
-			jQuery.boxModel && Math.max(document.documentElement["client" + name], document.body["client" + name]) ||
+			self["inner" + name] ||
+			jQuery.boxModel && document.documentElement["client" + name] ||
 			document.body["client" + name] :
 		
 			this[0] == document ?

comment:3 Changed 6 years ago by brandon

  • Status changed from reopened to closed
  • Resolution set to fixed

This is fixed in SVN. We can't use inner[Width/Height] for all browsers except IE because Opera and Mozilla include the width of the scroll bars.

comment:4 Changed 6 years ago by brandon

  • Milestone changed from 1.2.1 to 1.2.2

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.