Change the tag for 1.x on npm

Reported by:	m_gol	Owned by:
Priority:	low	Milestone:	1.12/2.2
Component:	build	Version:	2.1.1
Keywords:		Cc:	dmethvin
Blocked by:		Blocking:

Description

It turns out when doing npm install jquery@1.x, npm actually first recognizes it's a valid semver range and doesn't look at the tag at all. This has recently caused issues for npm itself so they banned such ranges on npm master, 2.0.0 will have this rule enforced.

Therefore, we have to change the 1.x tag to something that isn't a valid semver range. This can be verified via require('semver').validRange(tagName). This should return null.

Attachments (0)

Change History (4)

Changed September 03, 2014 08:08AM UTC by m_gol comment:1

We should also remove the current 1.x tag, after a year or two it's going to be banned on npm servers as well.

Perhaps we don't really need a tag since 1.x works fine as a semver range?

Changed October 16, 2014 07:12PM UTC by dmethvin comment:2

Once we reversion into *two* packages this won't be an issue. Is it possible to unpublish/remove a tag? If so I don't know how.

Changed October 17, 2014 09:25PM UTC by m_gol comment:3

@dmethvin It seems it's not possible now but soon will be; see https://github.com/npm/npm/issues/6243

Changed October 21, 2014 12:59AM UTC by m_gol comment:4

resolution:	→ migrated
status:	new → closed

Migrated to https://github.com/jquery/jquery/issues/1793

Side navigation