Side navigation
#15210 closed bug (migrated)
Opened August 12, 2014 10:13PM UTC
Closed October 21, 2014 12:56AM UTC
2.1.2-pre, ajax.js: environments that don't have 'location' variable will break
Reported by: | brianblocker | Owned by: | |
---|---|---|---|
Priority: | high | Milestone: | None |
Component: | ajax | Version: | 2.1.1 |
Keywords: | test | Cc: | |
Blocked by: | Blocking: |
Description
It appears that the change which removes the "IE workaround" on ajax.js now breaks environments that do not have window.location. To be specific:
(from https://github.com/jquery/jquery/blob/master/src/ajax.js#L44)
ajaxLocation = location.href,
When I try to run automated tests using jasmine-node, location is undefined (because there is no "browser" sorta), and therefore the test breaks. Using the previous version (2.1.1-pre) works fine, but it appears that the change introduced in 2.1.2-pre now breaks the environment.
Attachments (0)
Change History (2)
Changed August 13, 2014 02:52AM UTC by comment:1
status: | new → open |
---|
Changed October 21, 2014 12:56AM UTC by comment:2
resolution: | → migrated |
---|---|
status: | open → closed |
Migrated to https://github.com/jquery/jquery/issues/1788
Since this is a regression, I'd like to fix it. However, we don't unit test or support jasmine-node so to have any chance to do this we'll need your help. Can you propose a fix as a pull request?