Bug Tracker

Modify

Ticket #150 (closed bug: fixed)

Opened 7 years ago

Last modified 4 years ago

[PATCH] slide & fade functions

Reported by: ieure Owned by:
Priority: undecided Milestone:
Component: ajax Version:
Keywords: patch Cc: ""
Blocking: Blocked by:

Description (last modified by dmethvin) (diff)

With v1.0, the old method of doing:

$(foo).slideDown().fadeIn();

No longer works as expected. I've written convenience methods to slide up & down while fading so I can replicate this behavior with v1.0.

Attachments

slide.patch Download (757 bytes) - added by ieure 7 years ago.
Patch implementing slide/fade convenience methods.
slide.2.patch Download (757 bytes) - added by ieure 7 years ago.
Patch implementing slide/fade convenience methods.

Change History

Changed 7 years ago by ieure

Patch implementing slide/fade convenience methods.

Changed 7 years ago by ieure

Patch implementing slide/fade convenience methods.

comment:1 Changed 7 years ago by ieure

I can't seem to attach the patch, so here is is, inline:

--- jquery-1.0.js.orig 2006-08-25 22:02:22.000000000 -0700 +++ jquery-1.0.js 2006-08-28 14:23:42.000000000 -0700 @@ -1253,6 +1253,21 @@

});

},

+ slideUpFade: function(speed, callback) { + return this.animate({height: "hide", opacity: "hide"}, speed, callback); + }, + + slideDownFade: function(speed, callback) { + return this.animate({height: "show", opacity: "show"}, speed, callback); + }, + + slideFadeToggle: function(speed, callback) { + return this.each(function() { + var state = $(this).is(":hidden") ? "show" : "hide"; + $(this).animate({height: state, opacity: state}, speed, callback); + }); + }, +

fadeIn: function(speed,callback){

return this.animate({opacity: "show"}, speed, callback);

},

comment:2 Changed 7 years ago by ieure

Awesome. That won't work, either.

Here's a link:  http://atomized.org/wp-content/slide.patch

comment:3 Changed 6 years ago by montanaharki

I've run into an error when using IE7 and the same animate functionality. If I setup a slideDownFade and a slideUpFade on hover, it will only operate once. Works fine on ie6, and ff2

comment:4 Changed 4 years ago by dmethvin

  • Status changed from new to closed
  • Description modified (diff)
  • Type set to bug
  • Component set to ajax
  • Priority set to blocker
  • need set to Review
  • Resolution set to fixed

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.